Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow react 16 as peerDependency #23

Merged
merged 5 commits into from
Nov 29, 2017
Merged

Conversation

okize
Copy link
Contributor

@okize okize commented Nov 2, 2017

Add prop-types & create-react-class packages to make the minimum amount of changes to be compatible with React 16.

@benbriggs
Copy link
Contributor

👍 thanks! i'm going to follow up with a migration of the example files to 16 as well.

@benbriggs
Copy link
Contributor

I'm going to open up an issue to switch bundled components to ES6 classes so that we don't need the create-react-class dependency long term (even though i prefer the original factory function style 😢 )

@benbriggs benbriggs merged commit 4fbfcc7 into HubSpot:master Nov 29, 2017
@benbriggs
Copy link
Contributor

@okize landed in 1.5.2

@okize
Copy link
Contributor Author

okize commented Dec 1, 2017

thanks @benbriggs !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants