switch out order of rendering, refactor css #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benbriggs
Pros
tabIndex
orderabsolute
positioning, content now manages its own spaceli
from the button so that we can have granular control over the child elements (with something likeflexbox
)Con
Will break current implementations (probably)…but not that badly. Just if people were depending on the
li
or not including our CSS (because they wanted buttons at the top). But this will allow for granular control from each supplied button so in the long run, I think it's a win.Consideration
tabIndex
but ultimately decided against it for two reasons: