Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request form fixes #1119

Merged
merged 16 commits into from
Jul 7, 2016
Merged

Request form fixes #1119

merged 16 commits into from
Jul 7, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Jul 1, 2016

Makes the following changes in the New/Edit Request Form:

  • Fix the Owners field - now it's a multi-input instead of a multi-select. Much more appropriate for the field type.
  • Fix many, many linting errors
  • Use the same field metadata style as the New Deploy form
  • Validate fields (eg. number fields fail if they can't be parsed as an int)
  • Feedback to user on which fields are preventing the form from being submitted
  • Use FormGroup components instead of writing out the form groups

@Calvinp
Copy link
Contributor Author

Calvinp commented Jul 5, 2016

@tpetr @wolfd @kwm4385 This is now ready for you to take a look (and the diff is nice).

@Calvinp Calvinp mentioned this pull request Jul 6, 2016
@tpetr
Copy link
Contributor

tpetr commented Jul 7, 2016

LGTM

@Calvinp Calvinp merged commit 8ac18b2 into decaf Jul 7, 2016
@ssalinas ssalinas deleted the request_form_fixes branch November 1, 2016 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants