Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update metric Otel conversion #47

Merged
merged 3 commits into from
Sep 11, 2024
Merged

update metric Otel conversion #47

merged 3 commits into from
Sep 11, 2024

Conversation

narcis96
Copy link

No description provided.

@narcis96 narcis96 force-pushed the narcis/modify_attr branch 11 times, most recently from 3e5c69f to 4a0fb34 Compare September 10, 2024 12:14
heitorganzeli
heitorganzeli requested changes Sep 10, 2024
View reviewed changes
Copy link

@heitorganzeli heitorganzeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to update the examples on README file, right?

@narcis96 narcis96 force-pushed the narcis/modify_attr branch 2 times, most recently from 738aa30 to caf7700 Compare September 11, 2024 07:58
@narcis96
Copy link
Author

you also need to update the examples on README file, right?

done

@narcis96 narcis96 force-pushed the narcis/modify_attr branch 3 times, most recently from 9bd8673 to 92b9d1e Compare September 11, 2024 09:30
@heitorganzeli
Copy link

now it looks like code wasn't changed... did you merge those other changes already?

also, if you put namespace on resource, are you creating new resource objects if you get different namespaces from the metrics?

@narcis96
Copy link
Author

narcis96 commented Sep 11, 2024 •
edited
Loading

now it looks like code wasn't changed... did you merge those other changes already?

there was a git issue. fixed now.

also, if you put namespace on resource, are you creating new resource objects if you get different namespaces from the metrics?

yes, all metrics within the same namespace belong to the same "resource metric" object. Check the README or the integration test for examples.

heitorganzeli
heitorganzeli approved these changes Sep 11, 2024
View reviewed changes
Copy link

@heitorganzeli heitorganzeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@heitorganzeli heitorganzeli merged commit db04631 into main Sep 11, 2024
138 of 147 checks passed
@narcis96 narcis96 deleted the narcis/modify_attr branch September 11, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorganzeli heitorganzeli heitorganzeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narcis96 @heitorganzeli