[Feature] Read aad2 scopes from environment variables #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickRimmer
changed the title
|
@NickRimmer Thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Huachao,
Thank you a lot for your work and such a great plugin. Looks very promising for me to use.
I would like to suggest a very tiny PR with a feature. I found that all AAD settings can be set per environment except scopes. But on AAD, multiple app registrations can have different scopes (e.g. Dev/User.Default, Prod/User.Default, etc.).
It would be awesome if you could approve my PR and add this feature to your extension. I wasn't able to build
vsixpackage from your current master branch, so based it on a commit with tagv0.25.0and tested it on my local.Thank you (;