Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cookies #8

Closed
ganlhi opened this issue Jul 1, 2016 · 7 comments
Closed

Use cookies #8

ganlhi opened this issue Jul 1, 2016 · 7 comments

Comments

@ganlhi
Copy link

ganlhi commented Jul 1, 2016

As far as I can see, cookies received by previous requests are not automatically sent with subsequent requests to the same host. Woul it be possible?

@Huachao
Copy link
Owner

Huachao commented Jul 1, 2016

@ganlhi, thanks for your suggestion. If implement this, I may need to implement a cookie storage, I think this is low priority now. I will consider this later. And now you can copy the value in Set-Cookie header and paste in request. BTW, copy will be enable when VS Code release new version

@Huachao
Copy link
Owner

Huachao commented Jul 28, 2016

@ganlhi, I am considering the automatically sending/storing cookie feature, and I have a question that wants to discuss with you. As we all know, cookies can be persistent cookie(for browser, normally stored on disk and available until expire time), or session cookie(temporary and erase when browser close, no expire time in Set-Cookie header).
So I am not sure how we should handle the session cookie in my extension?

@ganlhi
Copy link
Author

ganlhi commented Jul 28, 2016

Well... I'm not an expert on implementing these things, but maybe you can consider a vscode window to be a browser instance, and so delete session cookies when window is closed?

@Huachao
Copy link
Owner

Huachao commented Jul 28, 2016

@ganlhi , or if I can handle these 2 kind of cookies in the way like browser, for persistent cookie, I will save them to local file system which can be reused next time; for session cookie, I will only save them in memory, and if VS Code is closed, our extension are inactive, and all the session cookie in memory are automatically removed. Next time you open vs code and activate our extension, you can only use the persistent cookie stored in file.

@ganlhi
Copy link
Author

ganlhi commented Jul 28, 2016

That seems a good idea!

Huachao added a commit that referenced this issue Aug 2, 2016
@Huachao Huachao closed this as completed Aug 2, 2016
@Huachao
Copy link
Owner

Huachao commented Aug 2, 2016

@ganlhi , this feature has been implemented in latest version 0.7.0, please help to verify it 🚀

@ganlhi
Copy link
Author

ganlhi commented Aug 16, 2016

Hey there! Good news!
Just got back from vacation. Will try this ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants