Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests variables and errors in file #184

Closed
colutti opened this issue Apr 5, 2018 · 2 comments
Closed

Requests variables and errors in file #184

colutti opened this issue Apr 5, 2018 · 2 comments

Comments

@colutti
Copy link

colutti commented Apr 5, 2018

With the latest commit we can now use requests variables, and that is great. One thing that I would change is the warning message you get when the request has not yet been sent. When using requests variables, requests that have not been sent marks the file as an "error" which causes the project to appear having issues, which is not a fact.

1
2

@Huachao
Copy link
Owner

Huachao commented Apr 5, 2018

@colutti nice catch, I original purpose is that using referencing a not sent request should be realized by user. However what you advised makes sense, I will update the diagnostic severity to Information form Error. And in this case you can still get notified that this potential issue.

@Huachao
Copy link
Owner

Huachao commented Apr 17, 2018

@colutti I have fixed this in 0.18.2, and you can upgrade the extension and verify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants