Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include additional headers during cmake install #795

Closed

Conversation

pabiswas
Copy link
Contributor

@pabiswas pabiswas commented Aug 17, 2023

cmake install only copies date/date.h in the installation path.
This PR adds the other headers in the installation path during cmake install.

@pabiswas pabiswas marked this pull request as draft August 17, 2023 11:21
@pabiswas pabiswas force-pushed the cmake_include_all_headers branch from 4c2f928 to 57de5c3 Compare August 17, 2023 11:24
@pabiswas pabiswas marked this pull request as ready for review August 17, 2023 11:28
@basilgello
Copy link
Contributor

This is useful change and it closely resembles the one Debian uses and I am using in Kodi (yet this change might need CMake older than 3.15). I am now going to check if this PR works as expected with current CMake and CMake < 3.15 before I mark it as ready.

CMakeLists.txt Outdated Show resolved Hide resolved
@basilgello
Copy link
Contributor

basilgello commented Sep 29, 2024

Great! Although not principal, the changed line should be indented for better readability. I dont know why Android client app for Github that I use has chewed leading spaces :(

@basilgello
Copy link
Contributor

@HowardHinnant can be merged with indentation fix :)

@HowardHinnant
Copy link
Owner

I'm not comfortable making this change. It isn't that I don't like the change. It is that I don't understand the git process well enough to be assured I will make the change without messing it up.

@basilgello
Copy link
Contributor

Moment, let me do the branch off it and show how it should look like!

@basilgello
Copy link
Contributor

git checkout master
git pull
git fetch https://github.com/basilgello/date include-headers
git merge --ff FETCH_HEAD

Branch: https://github.com/basilgello/date/commits/include-headers

@HowardHinnant
Copy link
Owner

Thanks! Merged: 3613526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants