Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation when MISSING_LEAP_SECONDS is set to true #780

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Conversation

techtim
Copy link

@techtim techtim commented Mar 3, 2023

When define MISSING_LEAP_SECONDS throws compile time error: 'load_just_leaps' was not declared in this scope
when find_read_and_leap_seconds tries to call load_just_leaps which surrounded with #if !MISSING_LEAP_SECONDS
This commit surrounds call to load_just_leaps

@HowardHinnant
Copy link
Owner

What are the symptoms that are being fixed? Compile-time error? Run-time error?

I would've guessed that if this code couldn't find leap second information it would just return the empty vector.

@techtim
Copy link
Author

techtim commented Mar 4, 2023

compile time error: 'load_just_leaps' was not declared in this scope

@HowardHinnant HowardHinnant merged commit 50acf3f into HowardHinnant:master Mar 4, 2023
@HowardHinnant
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants