Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out-of-memory issue #889

Merged
merged 6 commits into from
Feb 3, 2023
Merged

Fix out-of-memory issue #889

merged 6 commits into from
Feb 3, 2023

Conversation

AlecAivazis
Copy link
Collaborator

@AlecAivazis AlecAivazis commented Feb 3, 2023

Fixes #886

This PR fixes an out of memory error encountered when fragments referenced each other

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2023

🦋 Changeset detected

Latest commit: 536e7d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
houdini Patch
houdini-plugin-svelte-global-stores Patch
houdini-react Patch
houdini-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 2:28AM (UTC)
docs-next ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 2:28AM (UTC)

@AlecAivazis AlecAivazis changed the title Bug repro/js out of memory Fix out-of-memory issue Feb 3, 2023
@AlecAivazis AlecAivazis merged commit fcba9f0 into next Feb 3, 2023
@AlecAivazis AlecAivazis deleted the bug-repro/js-out-of-memory branch February 3, 2023 03:21
AlecAivazis added a commit that referenced this pull request Feb 10, 2023
* Add v8 error: JavaScript heap out of memory error

* added unit test that passes

* changeset

* remove test

* cleanup

---------

Co-authored-by: Seppe Dekeyser <[email protected]>
AlecAivazis added a commit that referenced this pull request Feb 10, 2023
* Add v8 error: JavaScript heap out of memory error

* added unit test that passes

* changeset

* remove test

* cleanup

---------

Co-authored-by: Seppe Dekeyser <[email protected]>
@AlecAivazis AlecAivazis mentioned this pull request Feb 10, 2023
endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
* Add v8 error: JavaScript heap out of memory error

* added unit test that passes

* changeset

* remove test

* cleanup

---------

Co-authored-by: Seppe Dekeyser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants