stale #849
Merged
stale #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 638e751 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AlecAivazis
requested changes
Jan 25, 2023
| /** | ||
| * Specifies after how long a data goes stale in miliseconds. (default: `undefined`) | ||
| */ | ||
| defaultTimeToStale?: number |
There was a problem hiding this comment.
Reminder for me to think about this name
There was a problem hiding this comment.
To bring even more things in mind, it would be cool to have:
{
stale: {
defaultTimeToStale: number | undefined
type: {
User: number | undefined
...
}
}
}
Merged
AlecAivazis
added a commit
that referenced
this pull request
Feb 10, 2023
* 🚧 UPDATE: stale v2 to v3 ^^ * 🚸 UPDATE: with TODOs * 👌 FIX: with feedback v0 * ⚡ IMPROVE: stale story * rename defaultTimeToStale to defaultLifetime * add garbage collection * linter * tests pass * consolidate cache methods * fix syntax issue * unused import * tests pass * grammar * add stale section to cache guide * link * fix link * changeset * remove unused tests * clean up links file --------- Co-authored-by: Alec Aivazis <[email protected]>
AlecAivazis
added a commit
that referenced
this pull request
Feb 10, 2023
* 🚧 UPDATE: stale v2 to v3 ^^ * 🚸 UPDATE: with TODOs * 👌 FIX: with feedback v0 * ⚡ IMPROVE: stale story * rename defaultTimeToStale to defaultLifetime * add garbage collection * linter * tests pass * consolidate cache methods * fix syntax issue * unused import * tests pass * grammar * add stale section to cache guide * link * fix link * changeset * remove unused tests * clean up links file --------- Co-authored-by: Alec Aivazis <[email protected]>
Merged
endigma
pushed a commit
to endigma/houdini
that referenced
this pull request
Nov 10, 2024
* 🚧 UPDATE: stale v2 to v3 ^^ * 🚸 UPDATE: with TODOs * 👌 FIX: with feedback v0 * ⚡ IMPROVE: stale story * rename defaultTimeToStale to defaultLifetime * add garbage collection * linter * tests pass * consolidate cache methods * fix syntax issue * unused import * tests pass * grammar * add stale section to cache guide * link * fix link * changeset * remove unused tests * clean up links file --------- Co-authored-by: Alec Aivazis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287
Adding
stalemechanism. withTo help everyone out, please make sure your PR does the following:
pnpm run testsandcd integration && pnpm run testspnpm changeset