Bidirectional cursor pagination #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7dfd768 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Merged
AlecAivazis
added a commit
that referenced
this pull request
Feb 10, 2023
* remove direction from refetch object * more store definitions * fix build errors * add missing methods to query store * add e2e test * fix initial args in bidirectional pagination test * add previous button * fix connection implementation on server * tidy up docs * treat updates as a list of strings to match against * start on query modification * only generate pagination queries that match the api * fix query arguments when loading pages * cache respects page info when handling cursor updates * bidirectional e2e query tests pass 🎉 * add tests for bidirectional fragments * tests pass * changesets * check pagination direction * linter * update snapshots * tidy up docs * release notes * remove logs * tidy up release notes * add license
AlecAivazis
added a commit
that referenced
this pull request
Feb 10, 2023
* remove direction from refetch object * more store definitions * fix build errors * add missing methods to query store * add e2e test * fix initial args in bidirectional pagination test * add previous button * fix connection implementation on server * tidy up docs * treat updates as a list of strings to match against * start on query modification * only generate pagination queries that match the api * fix query arguments when loading pages * cache respects page info when handling cursor updates * bidirectional e2e query tests pass 🎉 * add tests for bidirectional fragments * tests pass * changesets * check pagination direction * linter * update snapshots * tidy up docs * release notes * remove logs * tidy up release notes * add license
Merged
endigma
pushed a commit
to endigma/houdini
that referenced
this pull request
Nov 10, 2024
* remove direction from refetch object * more store definitions * fix build errors * add missing methods to query store * add e2e test * fix initial args in bidirectional pagination test * add previous button * fix connection implementation on server * tidy up docs * treat updates as a list of strings to match against * start on query modification * only generate pagination queries that match the api * fix query arguments when loading pages * cache respects page info when handling cursor updates * bidirectional e2e query tests pass 🎉 * add tests for bidirectional fragments * tests pass * changesets * check pagination direction * linter * update snapshots * tidy up docs * release notes * remove logs * tidy up release notes * add license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #670
This PR implements bidirectional cursor-based pagination. There's no real change for pretty much anyone except those who have provided custom stores (there's no more distinction between
forwardandbackwardstores). However, since this is a breaking change technically, I wanted to get it out for1.0To help everyone out, please make sure your PR does the following:
pnpm run testsandcd integration && pnpm run testspnpm changeset