Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change spread order to get deep merge #835

Merged

Conversation

sistrall
Copy link
Contributor

Fixes an issue due to the wrong order in merging custom stores configuration: in case only a subset of the standard store is customized, the names of the remaining ones get lost.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2023

⚠️ No Changeset found

Latest commit: 4f85082

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 19, 2023

@sistrall is attempting to deploy a commit to the HoudiniGraphQL Team on Vercel.

A member of the Team first needs to authorize it.

@AlecAivazis
Copy link
Collaborator

whoops!! Good catch 👍 mind adding a changeset?

@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs ❌ Failed (Inspect) Jan 19, 2023 at 8:34PM (UTC)

@vercel
Copy link

vercel bot commented Jan 19, 2023

Deployment failed with the following error:

Was unable to schedule a deployment.

@sistrall
Copy link
Contributor Author

@AlecAivazis I'd like to complete the checklist, sure, but I got issues with pnpm i: it seems turbo is not installed on my machine or something like that. As soon as I move on, I'll add the changeset.

@AlecAivazis
Copy link
Collaborator

Hey @sistrall! Mind changing the target of your PR to the next branch?

@sistrall sistrall changed the base branch from main to next January 24, 2023 08:56
@AlecAivazis AlecAivazis merged commit 81eb2b4 into HoudiniGraphql:next Jan 30, 2023
@AlecAivazis
Copy link
Collaborator

I'm just going to merge this in - don't worry about the changeset

endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants