Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load with satisfies expression #793

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Load with satisfies expression #793

merged 2 commits into from
Dec 27, 2022

Conversation

AlecAivazis
Copy link
Collaborator

Fixes #792

This PR fixes a bug when using the satisfies keyword with load functions

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2022

🦋 Changeset detected

Latest commit: 968ec84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
houdini-svelte Patch
houdini Patch
houdini-plugin-svelte-global-stores Patch
houdini-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 27, 2022 at 5:22PM (UTC)
docs-next ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 27, 2022 at 5:22PM (UTC)

@AlecAivazis AlecAivazis changed the title Load with parens Load with satisfies expression Dec 27, 2022
@AlecAivazis AlecAivazis merged commit d3ba00f into main Dec 27, 2022
@AlecAivazis AlecAivazis deleted the load-with-parens branch December 27, 2022 17:27
@github-actions github-actions bot mentioned this pull request Dec 27, 2022
@524c
Copy link
Contributor

524c commented Dec 27, 2022

Hey @AlecAivazis

I don't know if you're still doing some debugging, but currently you have two console.log calls in this file 😁

houdini code
houdini-ast-file

@AlecAivazis
Copy link
Collaborator Author

damn!! thanks for catching that. I'll push up a fix now

@524c
Copy link
Contributor

524c commented Dec 27, 2022

damn!! thanks for catching that. I'll push up a fix now

tks!!

@AlecAivazis
Copy link
Collaborator Author

I guess that's what I get for trying to fix things while spending time with family 🤦

@AlecAivazis AlecAivazis mentioned this pull request Dec 27, 2022
5 tasks
@524c
Copy link
Contributor

524c commented Dec 27, 2022

I guess that's what I get for trying to fix things while spending time with family 🤦

Yes, I know how it is 😆

endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
* fix bug using satisfies expression with load functions

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple exports with the same name "load" for +layout.server.ts
2 participants