Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@list & custom IDs #773

Merged
merged 5 commits into from
Dec 16, 2022
Merged

@list & custom IDs #773

merged 5 commits into from
Dec 16, 2022

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Dec 16, 2022

Taking into account custom IDs for global identification in @list
Also, adding paginate error only on paginate directive

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2022

🦋 Changeset detected

Latest commit: 136f570

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
houdini Patch
houdini-react Patch
houdini-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 9:08AM (UTC)
docs-next ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 9:08AM (UTC)

@AlecAivazis AlecAivazis merged commit 57ea21c into main Dec 16, 2022
@AlecAivazis AlecAivazis deleted the fix/list-custom-ids branch December 16, 2022 09:15
@github-actions github-actions bot mentioned this pull request Dec 16, 2022
endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
…ql#773)

* 🐛 FIX: obj identification

* 🚸 UPDATE: don't log paginate error on a list dir

* ✏️ DOC: tentative

* 👌 UPDATE: even better tests with extra field

* tweak variable name

Co-authored-by: Alec Aivazis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants