Fix/is fetching #686
Merged
Fix/is fetching #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 298ce49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AlecAivazis
approved these changes
Nov 10, 2022
Merged
endigma
pushed a commit
to endigma/houdini
that referenced
this pull request
Nov 10, 2024
* ⚡ FIX: setConfig already done in BaseStore * 🚸 IMPROVE: isFetching to happen only when a network call really happen. * ✏️ DOC: changeset * ✏️ DOC: changeset * ✅ UPDATE: with tests * track false fetching state when loading pages Co-authored-by: Alec Aivazis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
Query, initial state isisFetching: true, then we call onlysetFetching(true)when there is a real network call ongoing.Going back to
isFetching: falsewill be part of the full store update. (to not be in situation where isFetching is false but we don't have data yet.Update the first line to point to the ticket that this PR fixespnpm run testsandcd integration && pnpm run testspnpm changeset