Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shebang and relative imports #630

Merged
merged 6 commits into from
Oct 22, 2022
Merged

Shebang and relative imports #630

merged 6 commits into from
Oct 22, 2022

Conversation

AlecAivazis
Copy link
Collaborator

@AlecAivazis AlecAivazis commented Oct 22, 2022 •
edited
Loading

Fixes #629 , fixes #628

This PR fixes 2 issues introduced in 0.17:

  • there was a missing shebang that prevented node LTS from executing cmd correctly
  • for non-entries, the resolveId logic was breaking the source path, making vite unable to import relative to them and resulting in some noisy logs.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 61d6ccd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
houdini-svelte Patch
houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Oct 22, 2022 at 3:37AM (UTC)
docs-next ✅ Ready (Inspect) Visit Preview Oct 22, 2022 at 3:37AM (UTC)

@AlecAivazis AlecAivazis changed the title Shebang Shebang and relative imports Oct 22, 2022
@AlecAivazis AlecAivazis merged commit 02d8fc4 into main Oct 22, 2022
@AlecAivazis AlecAivazis deleted the shebang branch October 22, 2022 03:41
@github-actions github-actions bot mentioned this pull request Oct 22, 2022
Merged
endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
@AlecAivazis @endigma
Shebang and relative imports (HoudiniGraphql#630)
c0cb7cc 
* add shebang to cmd

* simplify resolveId logic to do the equivalent of resolve_relative

* only perform resolve_relative on non-entries - leave old logic behind for entries

* changeset

* add comment

* more comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@AlecAivazis