Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only add data prop with inline queries #613

Merged
merged 2 commits into from
Oct 21, 2022
Merged

only add data prop with inline queries #613

merged 2 commits into from
Oct 21, 2022

Conversation

AlecAivazis
Copy link
Collaborator

Fixes #602

This PR tweaks the load generator so that it only adds enforces a data prop when there are inline queries that would use it

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs-next ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 0:00AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2022

🦋 Changeset detected

Latest commit: d9a8cb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
houdini-svelte Patch
houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlecAivazis AlecAivazis merged commit eb3ffe1 into main Oct 21, 2022
@AlecAivazis AlecAivazis deleted the no-extra-data branch October 21, 2022 00:06
This was referenced Oct 21, 2022
endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
* only add data prop with inline queries

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only add data prop when necessary
1 participant