Windows compat #612
Merged
Windows compat #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ca0ddc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jycouet
reviewed
Oct 19, 2022
endigma
pushed a commit
to endigma/houdini
that referenced
this pull request
Nov 10, 2024
* create path package * centralize import path logic * comments * remove os from runtime * add windows e2e test to workflow * add runs-on back * missing strategy key? * no need for ubuntu AND osx * add logs * some logs * so it begins * who cares * a * log dir contents * b * c * d * e * mkdir before build * glob needs unix paths * use os for playwright cache key * pnpm cache use matrix * remove ci caching * pnpm playwright * @playwright/test as top level dep * add cache back * changeset * copy over changes * add playwright cache check back * move glob to local fs * remove unused imports * remove unused imports * use default glob export * fix glob import in typedefs * remove playwright cache * more unused imports * fix sponsor link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #592
This PR is a slightly different approach to the windows compatibility issue than the original #605.
To help everyone out, please make sure your PR does the following:
pnpm run testsandcd integration && pnpm run testspnpm changeset