Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: windows path #585

Merged
merged 2 commits into from
Oct 4, 2022
Merged

🐛 FIX: windows path #585

merged 2 commits into from
Oct 4, 2022

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Oct 3, 2022

Fixes #583

To manage windows path. (path.posix doesn't work.)

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
    • We could add a windows tests in CI as well... It's all passing now. It it worth?
  • Includes a changeset if your fix affects the user with pnpm changeset

@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 8:46PM (UTC)
docs-next ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 8:46PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022

🦋 Changeset detected

Latest commit: 7fc1668

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlecAivazis AlecAivazis merged commit 29a8fcd into main Oct 4, 2022
@AlecAivazis AlecAivazis deleted the fix/windows-path branch October 4, 2022 07:09
@github-actions github-actions bot mentioned this pull request Oct 4, 2022
endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
* 🐛 FIX: windows path

* ✏️ UPDATE: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid module paths in generated types file on Windows
2 participants