Added further config to vite plugin #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6afd2f7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@sjcobb2022 is attempting to deploy a commit to the HoudiniGraphQL Team on Vercel. A member of the Team first needs to authorize it. |
No worries at all! I'd rather the little changes sprinkle in than not get caught 😄 Thanks for taking the time to fix it 👍 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Mind adding a changeset? |
AlecAivazis
approved these changes
Oct 4, 2022
|
I went ahead and added the changset for you. Thanks again! |
Merged
endigma
pushed a commit
to endigma/houdini
that referenced
this pull request
Nov 10, 2024
* Added further config * format * Added type imports * changeset Co-authored-by: Alec Aivazis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition to #566
After testing, there are some instances where the config is not passed into other functions. By adding extraconfig to all functions in vite, we are able to ensure that any additional config is always passed.
To help everyone out, please make sure your PR does the following:
pnpm run testsandcd integration && pnpm run testsSorry for all the little changes @AlecAivazis