Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/warning inline functions #509

Merged
merged 10 commits into from
Sep 4, 2022
Merged

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Sep 1, 2022

Warn people about outdated function: query, paginatedQuery, mutation, subscription in runtime!

It will look like
In SSR
image
In Client
image

Things that I started to tackle:

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs-next ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 4:58PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2022

🦋 Changeset detected

Latest commit: 4c5d127

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlecAivazis AlecAivazis merged commit 4983a76 into main Sep 4, 2022
@AlecAivazis AlecAivazis deleted the feat/warning-inline-functions branch September 4, 2022 17:14
This was referenced Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants