Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimistic update types #490

Merged
merged 11 commits into from
Aug 27, 2022
Merged

Optimistic update types #490

merged 11 commits into from
Aug 27, 2022

Conversation

AlecAivazis
Copy link
Collaborator

This PR fixes the generated types for optimistic responses. The types do not include transient fields from included fragments in order to avoid an anti-pattern that couples the mutation invocation to fragments defined in unknown external files. Since there is no runtime cost to the duplicate selection, we are forcing users to be explicit about the fields they are providing optimistic values for.

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2022

🦋 Changeset detected

Latest commit: bac779a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs-next ✅ Ready (Inspect) Visit Preview Aug 27, 2022 at 7:35PM (UTC)

@AlecAivazis AlecAivazis enabled auto-merge (squash) August 27, 2022 19:35
@AlecAivazis AlecAivazis disabled auto-merge August 27, 2022 19:40
@AlecAivazis AlecAivazis merged commit 71caba7 into main Aug 27, 2022
@AlecAivazis AlecAivazis deleted the optimistic-update-types branch August 27, 2022 19:41
@github-actions github-actions bot mentioned this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant