Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verify_init script to support changed sv CLI options #1383

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

SeppahBaws
Copy link
Collaborator

This fixes currently broken builds, because of the deprecated CLI options in the svelte cli.
I also pinned the version of the cli to the current latest, 0.6, so that we don't have to do this again every time they push a non-backwards compatible change.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 5137276

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit 5137276
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/672966b489595900081d7113

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit 5137276
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/672966b45e8ecf0008340f6a

Copy link
Collaborator

@AlecAivazis AlecAivazis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this out

@AlecAivazis AlecAivazis merged commit 7287f24 into main Nov 5, 2024
15 checks passed
@AlecAivazis AlecAivazis deleted the fix-verify-init-action branch November 5, 2024 06:38
ewen-lbh pushed a commit to ewen-lbh/houdini-graphql that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants