Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support '.graphqls' file extension #1382

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Support '.graphqls' file extension #1382

merged 1 commit into from
Oct 29, 2024

Conversation

gschulze
Copy link
Contributor

Fixes #1381

Adds support for *.graphqls files in tooling.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d8097aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
houdini Patch
houdini-adapter-auto Patch
houdini-adapter-cloudflare Patch
houdini-adapter-node Patch
houdini-adapter-static Patch
houdini-react Patch
houdini-svelte Patch
houdini-plugin-svelte-global-stores Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Oct 28, 2024 •
edited
Loading

✅ Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit d8097aa
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/6720a87c30afd6000823a600

@netlify Netlify
Copy link

netlify bot commented Oct 28, 2024 •
edited
Loading

✅ Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit d8097aa
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/6720a87cdda78700086d9783

AlecAivazis
AlecAivazis previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@AlecAivazis AlecAivazis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough. Nice!

@AlecAivazis
Copy link
Collaborator

Oh, i just realized we'll need a changeset file. Mind adding one quickly so I can merge this?

@gschulze
Copy link
Contributor Author

Oh, i just realized we'll need a changeset file. Mind adding one quickly so I can merge this?

I've never worked with changesets before, otherwise I'd have done it already. Where do I need to put it?

@SeppahBaws
Copy link
Collaborator

Oh, i just realized we'll need a changeset file. Mind adding one quickly so I can merge this?

I've never worked with changesets before, otherwise I'd have done it already. Where do I need to put it?

Just run pnpm changeset in the repo and walk through the steps for adding a patch change

@gschulze
Copy link
Contributor Author

@AlecAivazis I added the changeset - I assume it's a patch. Would be nice if we could have a release of this change soon :)

@SeppahBaws
Copy link
Collaborator

Looks like you just need to run the prettier script for formatting, and then we can merge this 🙂

@gschulze
Copy link
Contributor Author

Looks like you just need to run the prettier script for formatting, and then we can merge this 🙂

Done.

SeppahBaws
SeppahBaws approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@SeppahBaws SeppahBaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding this!

@SeppahBaws SeppahBaws merged commit 24e6bef into HoudiniGraphql:main Oct 29, 2024
15 checks passed
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Merged
endigma pushed a commit to endigma/houdini that referenced this pull request Nov 23, 2024
@gschulze @endigma
Support '.graphqls' file extension (HoudiniGraphql#1382)
c2f2536
ewen-lbh pushed a commit to ewen-lbh/houdini-graphql that referenced this pull request Dec 21, 2024
@gschulze @ewen-lbh
Support '.graphqls' file extension (HoudiniGraphql#1382)
2538d3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeppahBaws SeppahBaws SeppahBaws approved these changes

@AlecAivazis AlecAivazis AlecAivazis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support '*.graphqls' files in tooling
3 participants
@gschulze @AlecAivazis @SeppahBaws