Fix init script using incorrect houdini-svelte version #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0357868 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for houdinigraphql canceled.
|
✅ Deploy Preview for houdini-docs-next canceled.
|
SeppahBaws
force-pushed
the
init-script-houdini-svelte-version
branch
from
1510789 to
0357868
Compare
|
Needed to tweak the github action to use the new sv cli tool since it replaces create-svelte |
AlecAivazis
approved these changes
Oct 25, 2024
Merged
endigma
pushed a commit
to endigma/houdini
that referenced
this pull request
Nov 23, 2024
ewen-lbh
pushed a commit
to ewen-lbh/houdini-graphql
that referenced
this pull request
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
npx houdini initon a brand new svelte project, the init script would incorrectly assume the version for thehoudinipackage is the same as the version for thehoudini-sveltepackage.This PR fixes it by altering the build script to fetch the package.json files for all the packages, and then either use
houdini's version, orhoudini-svelte's versionTo help everyone out, please make sure your PR does the following:
pnpm run testsandcd integration && pnpm run testspnpm changeset