Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add using keyword support #1286

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

Hebilicious
Copy link
Contributor

@Hebilicious Hebilicious commented Mar 19, 2024

Resolves #1287

Context :

The following error message appears when trying to use the new javascript using keyword (https://github.com/tc39/proposal-explicit-resource-management)

$ vite dev
:x: Encountered error in src/routes/sverdle/+page.server.ts
This experimental syntax requires enabling the parser plugin: "explicitResourceManagement". (14:1)
error when starting dev server:
undefined

Typescript >5.2 support this out of the box, and there's a babel plugin that can be leveraged to support this.

I've tested the changes with a pnpm patch on a new sveltekit project and was able to start the dev server without any errors.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: fbadc58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
houdini Patch
houdini-adapter-auto Patch
houdini-adapter-cloudflare Patch
houdini-adapter-node Patch
houdini-react Patch
houdini-svelte Patch
houdini-plugin-svelte-global-stores Patch
create-houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit fbadc58
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/6605b710a10d20000808ded6

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit fbadc58
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/6605b710d13d7900082faeee

@Hebilicious Hebilicious marked this pull request as draft March 19, 2024 15:35
@Hebilicious Hebilicious marked this pull request as ready for review March 19, 2024 16:21
@AlecAivazis
Copy link
Collaborator

Thanks for putting this together! Mind adding a patch changeset so we can cut a new version when this merges?

@Hebilicious
Copy link
Contributor Author

@AlecAivazis done

@SeppahBaws
Copy link
Collaborator

Looks like you just need to run prettier and then we can merge this 👍

@SeppahBaws
Copy link
Collaborator

@Hebilicious bump :)

@Hebilicious
Copy link
Contributor Author

@Hebilicious bump :)

Sorry I missed that ! Just ran it.

@SeppahBaws SeppahBaws merged commit f45e912 into HoudiniGraphql:main Mar 28, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Mar 28, 2024
endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
gwennlbh pushed a commit to gwennlbh/houdini-graphql that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the using keyword (explicit resource management)
3 participants