-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add using keyword support #1286
Conversation
🦋 Changeset detectedLatest commit: fbadc58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for houdinigraphql canceled.
|
✅ Deploy Preview for houdini-docs-next canceled.
|
Thanks for putting this together! Mind adding a |
@AlecAivazis done |
Looks like you just need to run prettier and then we can merge this 👍 |
@Hebilicious bump :) |
Sorry I missed that ! Just ran it. |
Resolves #1287
Context :
The following error message appears when trying to use the new javascript
using
keyword (https://github.com/tc39/proposal-explicit-resource-management)Typescript >5.2 support this out of the box, and there's a babel plugin that can be leveraged to support this.
I've tested the changes with a pnpm patch on a new sveltekit project and was able to start the dev server without any errors.
To help everyone out, please make sure your PR does the following:
pnpm run tests
andcd integration && pnpm run tests
pnpm changeset