Fix nested fragments getting masked out incorrectly #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 69a2f7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for houdinigraphql canceled.
|
✅ Deploy Preview for houdini-docs-next canceled.
|
SeppahBaws
changed the title
|
@AlecAivazis I think this PR is pretty much ready, however some of the e2e tests seem to still be failing. Could you take a look at this, as I can't seem to be able to get those running on my computer? |
|
No problem! I updated the snapshots, will merge this in once we get the 👍 from github |
AlecAivazis
previously approved these changes
Dec 25, 2023
AlecAivazis
approved these changes
Dec 26, 2023
Merged
endigma
pushed a commit
to endigma/houdini
that referenced
this pull request
Nov 10, 2024
) Co-authored-by: Alec Aivazis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1243
When fragments with arguments are nested, they ended up not having their arguments in the generated artifact of the parent fragment. This caused the fields in the nested fragment consuming those arguments to be masked out, as those fragments were instantiated with an empty arguments object.
To help everyone out, please make sure your PR does the following:
pnpm run testsandcd integration && pnpm run testspnpm changeset