Skip to content

Commit

Permalink
waitUntil domcontentloaded
Browse files Browse the repository at this point in the history
  • Loading branch information
AlecAivazis committed Mar 29, 2024
1 parent a4cd3cb commit e26d249
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion e2e/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"web": "vite dev",
"dev": "concurrently \"pnpm run web\" \"pnpm run api\" -n \"web,api\" -c \"green,magenta\"",
"build": "vite build",
"tests": "playwright test ",
"tests": "playwright test",
"test": "npm run tests",
"tw": "npx tailwindcss -i ./src/styles.css -o ./public/assets/output.css --watch",
"preview": "vite dev"
Expand Down
2 changes: 1 addition & 1 deletion e2e/react/src/utils/testsHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export async function locator_click(page: Page, selector: string) {
* @returns The response of the page
*/
export async function goto(page: Page, url: string): Promise<null | Response> {
const res = await page.goto(url)
const res = await page.goto(url, { waitUntil: 'domcontentloaded' })

Check failure on line 168 in e2e/react/src/utils/testsHelper.ts

View workflow job for this annotation

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/component_fields/arguments/test.ts:5:1 › Component fields with correct argument value

1) src/routes/component_fields/arguments/test.ts:5:1 › Component fields with correct argument value page.goto: net::ERR_EMPTY_RESPONSE at http://localhost:3008/component_fields/arguments =========================== logs =========================== navigating to "http://localhost:3008/component_fields/arguments", waiting until "domcontentloaded" ============================================================ at src/utils/testsHelper.ts:168 166 | */ 167 | export async function goto(page: Page, url: string): Promise<null | Response> { > 168 | const res = await page.goto(url, { waitUntil: 'domcontentloaded' }) | ^ 169 | await expect_n_gql(page, null, 0) 170 | return res 171 | } at goto (file:///home/runner/work/houdini/houdini/e2e/react/src/utils/testsHelper.ts:168:25) at file:///home/runner/work/houdini/houdini/e2e/react/src/routes/component_fields/arguments/test.ts:6:8

Check failure on line 168 in e2e/react/src/utils/testsHelper.ts

View workflow job for this annotation

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/component_fields/arguments/test.ts:5:1 › Component fields with correct argument value

1) src/routes/component_fields/arguments/test.ts:5:1 › Component fields with correct argument value Retry #1 --------------------------------------------------------------------------------------- page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:3008/component_fields/arguments =========================== logs =========================== navigating to "http://localhost:3008/component_fields/arguments", waiting until "domcontentloaded" ============================================================ at src/utils/testsHelper.ts:168 166 | */ 167 | export async function goto(page: Page, url: string): Promise<null | Response> { > 168 | const res = await page.goto(url, { waitUntil: 'domcontentloaded' }) | ^ 169 | await expect_n_gql(page, null, 0) 170 | return res 171 | } at goto (file:///home/runner/work/houdini/houdini/e2e/react/src/utils/testsHelper.ts:168:25) at file:///home/runner/work/houdini/houdini/e2e/react/src/routes/component_fields/arguments/test.ts:6:8

Check failure on line 168 in e2e/react/src/utils/testsHelper.ts

View workflow job for this annotation

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/component_fields/arguments/test.ts:5:1 › Component fields with correct argument value

1) src/routes/component_fields/arguments/test.ts:5:1 › Component fields with correct argument value Retry #2 --------------------------------------------------------------------------------------- page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:3008/component_fields/arguments =========================== logs =========================== navigating to "http://localhost:3008/component_fields/arguments", waiting until "domcontentloaded" ============================================================ at src/utils/testsHelper.ts:168 166 | */ 167 | export async function goto(page: Page, url: string): Promise<null | Response> { > 168 | const res = await page.goto(url, { waitUntil: 'domcontentloaded' }) | ^ 169 | await expect_n_gql(page, null, 0) 170 | return res 171 | } at goto (file:///home/runner/work/houdini/houdini/e2e/react/src/utils/testsHelper.ts:168:25) at file:///home/runner/work/houdini/houdini/e2e/react/src/routes/component_fields/arguments/test.ts:6:8

Check failure on line 168 in e2e/react/src/utils/testsHelper.ts

View workflow job for this annotation

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/component_fields/arguments/test.ts:5:1 › Component fields with correct argument value

1) src/routes/component_fields/arguments/test.ts:5:1 › Component fields with correct argument value Retry #3 --------------------------------------------------------------------------------------- page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:3008/component_fields/arguments =========================== logs =========================== navigating to "http://localhost:3008/component_fields/arguments", waiting until "domcontentloaded" ============================================================ at src/utils/testsHelper.ts:168 166 | */ 167 | export async function goto(page: Page, url: string): Promise<null | Response> { > 168 | const res = await page.goto(url, { waitUntil: 'domcontentloaded' }) | ^ 169 | await expect_n_gql(page, null, 0) 170 | return res 171 | } at goto (file:///home/runner/work/houdini/houdini/e2e/react/src/utils/testsHelper.ts:168:25) at file:///home/runner/work/houdini/houdini/e2e/react/src/routes/component_fields/arguments/test.ts:6:8

Check failure on line 168 in e2e/react/src/utils/testsHelper.ts

View workflow job for this annotation

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/component_fields/simple/test.ts:5:1 › Component field happy path

2) src/routes/component_fields/simple/test.ts:5:1 › Component field happy path =================== page.goto: net::ERR_EMPTY_RESPONSE at http://localhost:3008/component_fields/simple =========================== logs =========================== navigating to "http://localhost:3008/component_fields/simple", waiting until "domcontentloaded" ============================================================ at src/utils/testsHelper.ts:168 166 | */ 167 | export async function goto(page: Page, url: string): Promise<null | Response> { > 168 | const res = await page.goto(url, { waitUntil: 'domcontentloaded' }) | ^ 169 | await expect_n_gql(page, null, 0) 170 | return res 171 | } at goto (file:///home/runner/work/houdini/houdini/e2e/react/src/utils/testsHelper.ts:168:25) at file:///home/runner/work/houdini/houdini/e2e/react/src/routes/component_fields/simple/test.ts:6:8

Check failure on line 168 in e2e/react/src/utils/testsHelper.ts

View workflow job for this annotation

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/component_fields/simple/test.ts:5:1 › Component field happy path

2) src/routes/component_fields/simple/test.ts:5:1 › Component field happy path =================== Retry #1 --------------------------------------------------------------------------------------- page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:3008/component_fields/simple =========================== logs =========================== navigating to "http://localhost:3008/component_fields/simple", waiting until "domcontentloaded" ============================================================ at src/utils/testsHelper.ts:168 166 | */ 167 | export async function goto(page: Page, url: string): Promise<null | Response> { > 168 | const res = await page.goto(url, { waitUntil: 'domcontentloaded' }) | ^ 169 | await expect_n_gql(page, null, 0) 170 | return res 171 | } at goto (file:///home/runner/work/houdini/houdini/e2e/react/src/utils/testsHelper.ts:168:25) at file:///home/runner/work/houdini/houdini/e2e/react/src/routes/component_fields/simple/test.ts:6:8

Check failure on line 168 in e2e/react/src/utils/testsHelper.ts

View workflow job for this annotation

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/component_fields/simple/test.ts:5:1 › Component field happy path

2) src/routes/component_fields/simple/test.ts:5:1 › Component field happy path =================== Retry #2 --------------------------------------------------------------------------------------- page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:3008/component_fields/simple =========================== logs =========================== navigating to "http://localhost:3008/component_fields/simple", waiting until "domcontentloaded" ============================================================ at src/utils/testsHelper.ts:168 166 | */ 167 | export async function goto(page: Page, url: string): Promise<null | Response> { > 168 | const res = await page.goto(url, { waitUntil: 'domcontentloaded' }) | ^ 169 | await expect_n_gql(page, null, 0) 170 | return res 171 | } at goto (file:///home/runner/work/houdini/houdini/e2e/react/src/utils/testsHelper.ts:168:25) at file:///home/runner/work/houdini/houdini/e2e/react/src/routes/component_fields/simple/test.ts:6:8

Check failure on line 168 in e2e/react/src/utils/testsHelper.ts

View workflow job for this annotation

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/component_fields/simple/test.ts:5:1 › Component field happy path

2) src/routes/component_fields/simple/test.ts:5:1 › Component field happy path =================== Retry #3 --------------------------------------------------------------------------------------- page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:3008/component_fields/simple =========================== logs =========================== navigating to "http://localhost:3008/component_fields/simple", waiting until "domcontentloaded" ============================================================ at src/utils/testsHelper.ts:168 166 | */ 167 | export async function goto(page: Page, url: string): Promise<null | Response> { > 168 | const res = await page.goto(url, { waitUntil: 'domcontentloaded' }) | ^ 169 | await expect_n_gql(page, null, 0) 170 | return res 171 | } at goto (file:///home/runner/work/houdini/houdini/e2e/react/src/utils/testsHelper.ts:168:25) at file:///home/runner/work/houdini/houdini/e2e/react/src/routes/component_fields/simple/test.ts:6:8

Check failure on line 168 in e2e/react/src/utils/testsHelper.ts

View workflow job for this annotation

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/handle/test.ts:6:1 › handle fetch remembers server-side variables

3) src/routes/handle/test.ts:6:1 › handle fetch remembers server-side variables ================== page.goto: net::ERR_EMPTY_RESPONSE at http://localhost:3008/handle/2 =========================== logs =========================== navigating to "http://localhost:3008/handle/2", waiting until "domcontentloaded" ============================================================ at src/utils/testsHelper.ts:168 166 | */ 167 | export async function goto(page: Page, url: string): Promise<null | Response> { > 168 | const res = await page.goto(url, { waitUntil: 'domcontentloaded' }) | ^ 169 | await expect_n_gql(page, null, 0) 170 | return res 171 | } at goto (file:///home/runner/work/houdini/houdini/e2e/react/src/utils/testsHelper.ts:168:25) at file:///home/runner/work/houdini/houdini/e2e/react/src/routes/handle/test.ts:13:8

Check failure on line 168 in e2e/react/src/utils/testsHelper.ts

View workflow job for this annotation

GitHub Actions / End-to-End Tests (ubuntu-latest, e2e-react)

src/routes/handle/test.ts:6:1 › handle fetch remembers server-side variables

3) src/routes/handle/test.ts:6:1 › handle fetch remembers server-side variables ================== Retry #1 --------------------------------------------------------------------------------------- page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:3008/handle/2 =========================== logs =========================== navigating to "http://localhost:3008/handle/2", waiting until "domcontentloaded" ============================================================ at src/utils/testsHelper.ts:168 166 | */ 167 | export async function goto(page: Page, url: string): Promise<null | Response> { > 168 | const res = await page.goto(url, { waitUntil: 'domcontentloaded' }) | ^ 169 | await expect_n_gql(page, null, 0) 170 | return res 171 | } at goto (file:///home/runner/work/houdini/houdini/e2e/react/src/utils/testsHelper.ts:168:25) at file:///home/runner/work/houdini/houdini/e2e/react/src/routes/handle/test.ts:13:8
await expect_n_gql(page, null, 0)
return res
}
Expand Down

0 comments on commit e26d249

Please sign in to comment.