Skip to content

Commit

Permalink
Fix eslint problems
Browse files Browse the repository at this point in the history
  • Loading branch information
SeppahBaws committed May 23, 2024
1 parent cec86db commit be17235
Show file tree
Hide file tree
Showing 7 changed files with 196 additions and 182 deletions.
11 changes: 8 additions & 3 deletions e2e/kit/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = {
'plugin:svelte/recommended'
],
plugins: ['@typescript-eslint'],
ignorePatterns: ['*.cjs'],
ignorePatterns: ['*.cjs', '$houdini/**'],
overrides: [
{
files: ['*.svelte'],
Expand All @@ -20,7 +20,8 @@ module.exports = {
],
parserOptions: {
sourceType: 'module',
ecmaVersion: 2020
ecmaVersion: 2020,
extraFileExtensions: ['.svelte']
},
env: {
browser: true,
Expand All @@ -31,6 +32,10 @@ module.exports = {
'@typescript-eslint/ban-ts-comment': 'off',
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/no-empty-function': 'off',
'@typescript-eslint/no-non-null-assertion': 'off'
'@typescript-eslint/no-non-null-assertion': 'off',
// Disable svelte-check, as we already have that as a separate step
'svelte/valid-compile': 'off',
// With component queries, it is valid to have e.g. props that are only used through the _QueryVariables function.
'@typescript-eslint/no-unused-vars': 'off'
}
};
25 changes: 12 additions & 13 deletions e2e/kit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,39 +13,38 @@
"build:generate": "pnpm build: && npx houdini generate",
"build:test": "pnpm build: && pnpm test",
"build:build": "pnpm build: && pnpm build",
"package": "svelte-kit package",
"previewWeb": "vite preview --port 3007",
"preview": "concurrently \"pnpm run previewWeb\" \"pnpm run api\" -n \"web,api\" -c \"green,magenta\"",
"tests": "playwright test",
"test": "npm run tests",
"check": "svelte-check --tsconfig ./tsconfig.json",
"check:watch": "pnpm run check -- --watch",
"lint": "prettier --ignore-path .gitignore --check --plugin-search-dir=. . && eslint --ignore-path .gitignore .",
"format": "prettier --ignore-path .gitignore --write --plugin-search-dir=. ."
"lint": "prettier --ignore-path .gitignore --check . && eslint .",
"format": "prettier --ignore-path .gitignore --write ."
},
"devDependencies": {
"@kitql/helpers": "^0.8.2",
"@playwright/test": "1.44.0",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.5.3",
"@sveltejs/vite-plugin-svelte": "^3.0.2",
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.62.0",
"@sveltejs/adapter-auto": "^3.2.1",
"@sveltejs/kit": "^2.5.10",
"@sveltejs/vite-plugin-svelte": "^3.1.0",
"@typescript-eslint/eslint-plugin": "^7.10.0",
"@typescript-eslint/parser": "^7.10.0",
"concurrently": "7.1.0",
"cross-env": "^7.0.3",
"e2e-api": "workspace:^",
"eslint": "^8.57.0",
"eslint": "^8.56.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-svelte": "^2.35.1",
"eslint-plugin-svelte": "^2.39.0",
"houdini": "workspace:^",
"houdini-plugin-svelte-global-stores": "workspace:^",
"houdini-svelte": "workspace:^",
"prettier": "^3.2.5",
"prettier-plugin-svelte": "^3.2.2",
"svelte": "5.0.0-next.138",
"svelte-check": "^3.6.7",
"svelte-eslint-parser": "^0.33.1",
"svelte-preprocess": "^5.1.3",
"svelte-check": "^3.7.1",
"svelte-eslint-parser": "^0.36.0",
"svelte-preprocess": "^5.1.4",
"tslib": "^2.3.1",
"typescript": "^5.0.0",
"vite": "^5.1.6",
Expand Down
2 changes: 1 addition & 1 deletion e2e/kit/playwright.config.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ReporterDescription, defineConfig, devices } from '@playwright/test';
import { ReporterDescription, defineConfig } from '@playwright/test';

const reporters: ReporterDescription[] = [['list'], ['html', { open: 'never' }]];
if (process.env.CI) {
Expand Down
1 change: 0 additions & 1 deletion e2e/kit/src/lib/QueryComponent.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
};
};
// svelte-ignore unused-export-let
export let id = '';
$: result = graphql(`
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { expect, test } from '@playwright/test';
import { routes } from '../../lib/utils/routes.js';
import { expect_1_gql, expect_to_be, goto } from '../../lib/utils/testsHelper.js';
import { goto } from '../../lib/utils/testsHelper.js';
import { sleep } from '@kitql/helpers';

test('Nested fragment argument masking', async ({ page }) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { expect, test } from '@playwright/test';
import { test } from '@playwright/test';
import { routes } from '../../../../lib/utils/routes.js';
import { expect_1_gql, expect_to_be, goto } from '../../../../lib/utils/testsHelper.js';

Expand Down
Loading

0 comments on commit be17235

Please sign in to comment.