Bump kit peer dependency to 1.0 (#763)

* 🎉 UPDATE: SvelteKit 1.0 * 🐛 IMPROVE: typos * fix cache disabled logic * changeset Co-authored-by: jycouet <[email protected]>
HoudiniGraphql · Dec 14, 2022 · 9c096a0 · 9c096a0 · vercel · Dec 14, 2022
1 parent f107a0e
commit 9c096a0
Show file tree

Hide file tree

Showing 12 changed files with 346 additions and 481 deletions.
diff --git a/.changeset/pink-dogs-cover.md b/.changeset/pink-dogs-cover.md
@@ -0,0 +1,6 @@
+---
+'houdini': patch
+'houdini-svelte': patch
+---
+
+bump kit peerDepency to 1.0.0
diff --git a/e2e/sveltekit/package.json b/e2e/sveltekit/package.json
@@ -20,9 +20,9 @@
   },
   "devDependencies": {
     "@kitql/helper": "^0.5.0",
-    "@playwright/test": "1.25.0",
-    "@sveltejs/adapter-auto": "1.0.0-next.90",
-    "@sveltejs/kit": "1.0.0-next.577",
+    "@playwright/test": "1.28.1",
+    "@sveltejs/adapter-auto": "1.0.0",
+    "@sveltejs/kit": "1.0.0",
     "@typescript-eslint/eslint-plugin": "^5.10.1",
     "@typescript-eslint/parser": "^5.10.1",
     "concurrently": "7.1.0",
@@ -35,12 +35,12 @@
     "houdini-svelte": "workspace:^",
     "prettier": "^2.5.1",
     "prettier-plugin-svelte": "^2.5.0",
-    "svelte": "3.52.0",
+    "svelte": "3.55.0",
     "svelte-check": "^2.2.6",
     "svelte-preprocess": "^4.10.1",
     "tslib": "^2.3.1",
     "typescript": "~4.6.2",
-    "vite": "^3.2.4",
+    "vite": "^4.0.1",
     "vite-plugin-lib-reporter": "^0.0.6"
   }
 }
diff --git a/e2e/sveltekit/src/routes/stores/fragment-null/spec.ts b/e2e/sveltekit/src/routes/stores/fragment-null/spec.ts
@@ -4,7 +4,7 @@ import { expectToBe, goto } from '../../../lib/utils/testsHelper.js';
 
 test.describe('fragment store', function () {
   test('accepts and returns null values', async function ({ page }) {
-    goto(page, routes.Stores_Mutation_Scalars);
+    await goto(page, routes.Stores_Fragment_Null);
 
     // make sure that the result updated with unmarshaled data
     await expectToBe(page, 'null');

diff --git a/e2e/sveltekit/src/routes/stores/prefetch-[userId]/spec.ts b/e2e/sveltekit/src/routes/stores/prefetch-[userId]/spec.ts
@@ -24,7 +24,7 @@ test.describe('prefetch-[userId] Page', () => {
     // Data displayed should still be the same
     await expectToBe(page, dataDisplayedSSR);
 
-    // Hovering again previous link should not trigger a new request (it's already ion the cache) AND should not change sur data displayed
+    // Hovering again previous link should not trigger a new request (it's already in the cache) AND should not change sur data displayed
     await expect_0_gql(page, `a[id=previous]`, 'hover');
     // Data displayed should still be the same
     await expectToBe(page, dataDisplayedSSR);

diff --git a/example/package.json b/example/package.json
@@ -13,16 +13,16 @@
 	"devDependencies": {
 		"@graphql-yoga/node": "^2.8.0",
 		"@kitql/vite-plugin-watch-and-run": "^0.4.0",
-		"@sveltejs/kit": "1.0.0-next.577",
+		"@sveltejs/kit": "1.0.0",
 		"concurrently": "^6.2.1",
 		"graphql": "^15.8.0",
 		"houdini": "workspace:^",
 		"houdini-svelte": "workspace:^",
-		"svelte": "^3.50.0",
+		"svelte": "^3.55.0",
 		"svelte-preprocess": "^4.10.1",
 		"tslib": "^2.3.1",
 		"typescript": "^4.8.4",
-		"vite": "^3.2.4",
+		"vite": "^4.0.1",
 		"ws": "^8.8.1"
 	},
 	"dependencies": {

diff --git a/package.json b/package.json
@@ -28,16 +28,15 @@
 		"@changesets/changelog-git": "^0.1.13",
 		"@changesets/changelog-github": "^0.4.7",
 		"@changesets/cli": "^2.25.0",
-		"@playwright/test": "1.25.0",
-		"@sveltejs/adapter-vercel": "1.0.0-next.81",
+		"@playwright/test": "1.28.1",
+		"@sveltejs/adapter-vercel": "1.0.0",
 		"@theguild/eslint-config": "^0.1.0",
 		"@trivago/prettier-plugin-sort-imports": "^3.3.0",
 		"eslint-plugin-unused-imports": "^2.0.0",
 		"graphql": "^15.8.0",
-		"playwright-core": "1.25.0",
 		"prettier": "^2.7.0",
 		"turbo": "^1.5.5",
-		"vite": "^3.2.4",
+		"vite": "^4.0.1",
 		"vitest": "^0.23.4"
 	},
 	"dependencies": {

diff --git a/packages/_scripts/package.json b/packages/_scripts/package.json
@@ -14,7 +14,7 @@
 		"esbuild-plugin-alias": "^0.2.1",
 		"esbuild-plugin-replace": "^1.2.0",
 		"glob": "^8.0.3",
-		"rollup": "^2.79.1",
+		"rollup": "^3.7.4",
 		"rollup-plugin-typescript2": "^0.34.0",
 		"typescript": "^4.8.4"
 	}

diff --git a/packages/houdini-svelte/package.json b/packages/houdini-svelte/package.json
@@ -24,14 +24,14 @@
     },
     "dependencies": {
         "@kitql/helper": "^0.5.0",
-        "@sveltejs/kit": "1.0.0-next.577",
+        "@sveltejs/kit": "^1.0.0",
         "ast-types": "^0.15.1",
         "estree-walker": "^3.0.1",
         "graphql": "^15.8.0",
         "houdini": "workspace:^",
         "minimatch": "^5.1.0",
         "recast": "^0.21.5",
-        "svelte": "^3.52.0"
+        "svelte": "^3.55.0"
     },
     "devDependencies": {
         "@types/minimatch": "^5.1.2",

diff --git a/packages/houdini/package.json b/packages/houdini/package.json
@@ -25,10 +25,10 @@
         "@types/minimatch": "^5.1.2",
         "@types/node": "^18.7.23",
         "prettier": "^2.5.1",
-        "rollup": "^2.79.1",
+        "rollup": "^3.7.4",
         "scripts": "workspace:^",
         "turbo": "^1.5.4",
-        "vite": "^3.2.4",
+        "vite": "^4.0.1",
         "vitest": "^0.23.4"
     },
     "dependencies": {

diff --git a/packages/houdini/src/runtime/cache/cache.ts b/packages/houdini/src/runtime/cache/cache.ts
@@ -181,10 +181,13 @@ class CacheInternal {
 		this.lifetimes = lifetimes
 
 		// the cache should always be disabled on the server, unless we're testing
+		this._disabled = typeof globalThis.window === 'undefined'
 		try {
-			this._disabled = process.env.HOUDINI_TEST !== 'true'
+			if (process.env.HOUDINI_TEST === 'true') {
+				this._disabled = false
+			}
 		} catch {
-			this._disabled = typeof globalThis.window === 'undefined'
+			// if process.env doesn't exist, that's okay just use the normal value
 		}
 	}