Invalid numbers route param parse as undefined (#897)

* invalid number route params marshal into undefined

* linter

* treat all undefineds as undefined

* changeset

.changeset/pretty-lobsters-push.md

@@ -0,0 +1,5 @@
+---
+'houdini-svelte': patch
+---
+
+Invalid integer route paramters get unmarshaled as undefined

packages/houdini/src/runtime/lib/scalars.test.ts

@@ -956,6 +956,18 @@ describe('parseScalar', function () {
 			value: '1',
 			expected: 1,
 		},
+		{
+			title: 'invalid Int',
+			type: 'Int',
+			value: '',
+			expected: undefined,
+		},
+		{
+			title: 'invalid Float',
+			type: 'Float',
+			value: '',
+			expected: undefined,
+		},
 		{
 			title: 'Boolean',
 			type: 'Boolean',

packages/houdini/src/runtime/lib/scalars.ts

@@ -199,8 +199,12 @@ export function isScalar(config: ConfigFile, type: string) {
 export function parseScalar(
 	config: ConfigFile,
 	type: string,
-	value: string
-): string | number | boolean {
+	value?: string
+): string | number | boolean | undefined {
+	if (typeof value === 'undefined') {
+		return undefined
+	}
+
 	if (type === 'Boolean') {
 		return value === 'true'
 	}
@@ -211,10 +215,18 @@ export function parseScalar(
 		return value
 	}
 	if (type === 'Int') {
-		return parseInt(value, 10)
+		const result = parseInt(value, 10)
+		if (Number.isNaN(result)) {
+			return undefined
+		}
+		return result
 	}
 	if (type === 'Float') {
-		return parseFloat(value)
+		const result = parseFloat(value)
+		if (Number.isNaN(result)) {
+			return undefined
+		}
+		return result
 	}
 
 	// if we have a special parse function, use it