Update example and minor type tweaks (#569)

* 🐛 DOC: mutation (#560) * 🐛 DOC: mutation * 🚸 DOC: making it more clear * mutation result never null * subscription listen is optional * added changesets * fix build errors Co-authored-by: JYC <[email protected]>
HoudiniGraphql · Sep 25, 2022 · 08f834a · 08f834a · vercel · Sep 25, 2022
1 parent ad0ed5b
commit 08f834a
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/.changeset/large-forks-kneel.md b/.changeset/large-forks-kneel.md
@@ -0,0 +1,5 @@
+---
+'houdini': patch
+---
+
+Mutation result is never null
diff --git a/.changeset/sour-students-juggle.md b/.changeset/sour-students-juggle.md
@@ -0,0 +1,5 @@
+---
+'houdini': patch
+---
+
+Subscription.listen arguments are optional
diff --git a/src/runtime/stores/mutation.ts b/src/runtime/stores/mutation.ts
@@ -35,7 +35,7 @@ export class MutationStore<
 			metadata?: App.Metadata
 			fetch?: typeof globalThis.fetch
 		} & MutationConfig<_Data, _Input, _Optimistic> = {}
-	): Promise<_Data | null> {
+	): Promise<_Data> {
 		const config = await this.getConfig()
 
 		this.store.update((c) => {
@@ -132,7 +132,7 @@ export class MutationStore<
 			this.store.set(storeData)
 
 			// return the value to the caller
-			return storeData.data
+			return storeData.data ?? ({} as _Data)
 		} catch (error) {
 			this.store.update((s) => ({
 				...s,

diff --git a/src/runtime/stores/subscription.ts b/src/runtime/stores/subscription.ts
@@ -28,10 +28,10 @@ export class SubscriptionStore<_Data, _Input extends {}> extends BaseStore {
 		return this.store?.subscribe(...args)
 	}
 
-	async listen(variables: _Input) {
+	async listen(variables?: _Input) {
 		// @ts-expect-error: typechecking cjs/esm interop is hard
 		// pull the query text out of the compiled artifact
-		const { raw: text, selection } = artifact.default || artifact
+		const { raw: text, selection } = this.artifact.default || this.artifact
 
 		// subscription.listen is a no-op on the server
 		if (!isBrowser) {