Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented ISG based Supplemental policy in the AppControl Manager #520

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

HotCakeX
Copy link
Owner

This is a new type of supplemental policy that doesn't explicitly allow anything, instead it only activates the usage of the ISG, Intelligent Security Graph, on the system so reputable files can be automatically authorized.

Implemented ISG based Supplemental policy
@HotCakeX HotCakeX added the Enhancement 💯 New feature or request label Jan 12, 2025
@HotCakeX HotCakeX self-assigned this Jan 12, 2025
@Copilot Copilot bot review requested due to automatic review settings January 12, 2025 08:38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 15 out of 22 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • AppControl Manager/AppControl Manager.csproj: Language not supported
  • AppControl Manager/MainWindow.xaml: Language not supported
  • AppControl Manager/Pages/CreateSupplementalPolicy.xaml: Language not supported
  • AppControl Manager/Resources/ISGBasedSupplementalPolicy.xml: Language not supported
  • AppControl Manager/Pages/ConfigurePolicyRuleOptions.xaml.cs: Evaluated as low risk
  • AppControl Manager/Pages/AllowNewApps/AllowNewApps.xaml.cs: Evaluated as low risk
  • AppControl Manager/Pages/Deployment.xaml.cs: Evaluated as low risk
Comments suppressed due to low confidence (3)

AppControl Manager/Pages/CreateSupplementalPolicy.xaml.cs:857

  • The reference to Merger.Merge might be incorrect. It was previously SiPolicy.Merger.Merge. Ensure that Merger is correctly referenced or imported.
Merger.Merge(EmptyPolicyPath, [EmptyPolicyPath]);

AppControl Manager/Logic/Types And Definitions/CodeIntegrityPolicy.cs:225

  • The validation code for the XML file is commented out. This could lead to potential issues if the XML file is not validated. Please ensure the XML file is validated using the TESTCiPolicy method.
// TODO: The TESTCiPolicy must accept XML Document

AppControl Manager/MainWindow.xaml.cs:1572

  • [nitpick] The parameter name 'button3' is ambiguous. It should be renamed to something more descriptive, such as 'sidebarUnsignedBasePolicyConnect3'.
currentPage.SetVisibility(visibility, SidebarBasePolicyPathTextBox.Text, SidebarUnsignedBasePolicyConnect1, SidebarUnsignedBasePolicyConnect2, SidebarUnsignedBasePolicyConnect3);
@HotCakeX HotCakeX merged commit 78434ad into main Jan 12, 2025
2 checks passed
@HotCakeX HotCakeX deleted the Implemented-ISG-based-Supplemental-policy-creation branch January 12, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 💯 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant