Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Unit test patient model mixin #879

Merged
merged 3 commits into from
Dec 19, 2016

Conversation

mkly
Copy link
Contributor

@mkly mkly commented Dec 15, 2016

Changes proposed in this pull request:

  • Add mixin unit test for patient-name
  • Add unit model test for patient

cc @HospitalRun/core-maintainers

mkly added 2 commits December 15, 2016 14:42
- Add unit model test for patient
- Add mixin unit test fro patient-name
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't there a test for getPatientDisplayName? Or is the idea to just do some spot testing?

@mkly
Copy link
Contributor Author

mkly commented Dec 16, 2016

A little of both. I'm just picking things off as I see them. I figure the code base can always benefit from a little more coverage and I'm using them to get up to speed to start helping with functional requirements and issues. In this case I probably just forgot. Leave it open and I'll add those since it looks pretty simple to add. Thanks again. 🍹

- Add displayPatientName test for patient-name mixin
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR @mkly!

@jkleinsc jkleinsc merged commit 0b61f2f into HospitalRun:master Dec 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants