This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Define issues with MedicationDetails and tests #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add mixin unit test for `MedicationDetails` - Define issue where `getMedicationPrice` and `getMedicationName` do not return a value on first retrieval - Add documentation explaining issue with return values - Fix error on `getMedicationPrice` if attribute is not a promise - Remove duplicate calls to `get` when a promise is detected Not changing methods to use `Ember.RSVP.Promise` as anything that uses those methods would currently not be setup to handle a returned promise. This may want to be adjusted in the future.
jkleinsc
approved these changes
Dec 15, 2016
There was a problem hiding this comment.
Looks good to me. Thanks for the PR @mkly!
BTW - getMedicationPrice and getMedicationName are only used via computed properties on the medication model and those CPs fire when the value changes. Those functions could probably be moved out of the mixin and into the model since they are only used there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue with promise not being detected and defines issues with return values
Changes proposed in this pull request:
MedicationDetailsgetMedicationPriceandgetMedicationNamedonot return a value on first retrieval
getMedicationPriceif attribute is not a promisegetwhen a promise is detectedNot changing methods to use
Ember.RSVP.Promiseas anything that usesthose methods would currently not be setup to handle a returned
promise. This may want to be adjusted in the future.
cc @HospitalRun/core-maintainers