Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

#824 Update inventory quantity to not allow negative numbers, acceptance test added #848

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

marcorosas1991
Copy link
Contributor

Fixes #824.

Changes proposed in this pull request:

  • Updated inventory model to not allow negative numbers.
  • Updated inv-purchase model to not allow negative numbers.
  • Updated quantity-conv.js to consider negative quantities as an invalid number.
  • Added an acceptance test to make sure items with negative quantities cannot be added.
  • UI notifies when quantity is negative

screen shot 2016-12-08 at 11 22 01 pm

cc @HospitalRun/core-maintainers

Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR @marcorosas1991!

@jkleinsc jkleinsc merged commit 78ec35d into HospitalRun:master Dec 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants