Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Add unit test for select-values #841

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

mkly
Copy link
Contributor

@mkly mkly commented Dec 8, 2016

Changes proposed in this pull request:

  • Add unit test for select-values

Test aligns with current behavior if non-array value is passed in as the
first argument.

cc @HospitalRun/core-maintainers

- Add unit test for select-values

Test aligns with current behavior if non-array value is passed in as the
first argument.
@mkly
Copy link
Contributor Author

mkly commented Dec 8, 2016

Feel like this behavior may want to change to throwing an Error that gets handled. To me simply returning undefined results in a broken state at that point forward.

Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR @mkly!

@jkleinsc jkleinsc merged commit d1cd4d4 into HospitalRun:master Dec 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants