Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Add EmailValdition unit tests #838

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Add EmailValdition unit tests #838

merged 1 commit into from
Dec 8, 2016

Conversation

mkly
Copy link
Contributor

@mkly mkly commented Dec 7, 2016

Changes proposed in this pull request:

  • Add EmailValidation.emailRegex unit tests

cc @HospitalRun/core-maintainers

@mkly
Add EmailValdition unit tests
42e0d2a 
- Add `EmailValidation.emailRegex` unit tests
@mkly
Copy link
Contributor Author

mkly commented Dec 7, 2016

Hello,
Very interesting project. Decided to just dip my tow in the water to see how I get along with your process. Figured I couldn't do too much damage adding a unit test for an email regex. 🍹

jkleinsc
jkleinsc approved these changes Dec 8, 2016
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR @mkly!

@jkleinsc jkleinsc merged commit 12e58a6 into HospitalRun:master Dec 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkly @jkleinsc