Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

[Cleanup] eslint new-cap #810

Merged
merged 1 commit into from
Nov 17, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/authenticators/custom.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export default BaseAuthenticator.extend({

invalidate: function() {
if (this.useGoogleAuth) {
return new Ember.RSVP.resolve();
return Ember.RSVP.resolve();
} else {
return this._getPromise('DELETE');
}
Expand Down
2 changes: 2 additions & 0 deletions app/inventory/barcode/controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ export default Ember.Controller.extend({
barcodeUri: function() {
let id = this.get('model.id');
let name = this.get('model.name');

/* eslint new-cap: ['error', { 'capIsNew': false }] */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btecu why is this override needed here? I'm not seeing a new being used here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind... I see why now.

return Ember.$(document).JsBarcode(id, {
width: 1,
height: 20,
Expand Down
2 changes: 1 addition & 1 deletion app/mixins/progress-dialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default Ember.Mixin.create({

showProgressModal: function() {
let progressDialog = Ember.Object.create(this.get('progressDialogDefaults'));
progressDialog.progressBarStyle = new Ember.String.htmlSafe(progressDialog.progressBarStyle);
progressDialog.progressBarStyle = Ember.String.htmlSafe(progressDialog.progressBarStyle);
progressDialog.set('title', this.get('progressTitle'));
progressDialog.set('message', this.get('progressMessage'));
this.set('progressDialog', progressDialog);
Expand Down