Make eslint object-curly-spacing rule enforced #807
Conversation
Re: http://eslint.org/docs/rules/object-curly-spacing Realized my fork was out of date when started looking at this issue recently. I have previously used ember-suave, just getting started with eslint. Since many of the rules outlined in HospitalRun#732 aren’t part of eslint recommended https://github.com/DockYard/eslint-plugin-ember-suave/blob/master/config/recommended.js, I suggest adding the rules to the eslintrc.js so that they are enforced as they are fixed. If this PR is ok: - I’ll add the rest of the already completed rules from HospitalRun#732 in a follow-on PR. - I will go through the remaining rules from HospitalRun#732, and add the rule to the .eslintrc.js as the rules are fixed.
|
Not sure why Travis failed since I can run |
|
@amyrlam thanks for the PR! I'm in favor of updating .eslintrc.js as things are fixed. In regards to Travis failing, for some reason sometimes Travis fails (not sure why?) and I have to manually restart the build/test. I restarted the test and it now passed. |
|
Ah thanks for the restart. Will start on the others! |
|
@btecu The rules that you started in the PR's linked in #732 aren't enforced unless you list them. See: http://eslint.org/docs/rules/, Totally agree we should add If you want to work on this together feel free to ping me on the HospitalRun Slack! |
|
@amyrlam That's not correct. They are enforced in So once #732 is completed we'll have to remove the one you just add because it will be covered by |
|
That makes sense, once suave is added remove the duplicate rules. But for now this will keep the rules enforced and keeps the tracking in the code. Or, we could add suave now and override any rules that haven't been fixed yet. |
Fixes: part of #732
Relates to: #770 cc @btecu
Changes proposed in this pull request:
ember-suaverules #732 aren’t part of eslint recommended https://github.com/DockYard/eslint-plugin-ember-suave/blob/master/config/recommended.js, I suggest adding the rules to theeslintrc.js, so that they are enforced as they are fixed.Why? I just realized my fork was terribly out of date when I started looking at #732 recently. I have previously used ember-suave, am just getting started with eslint.
If this PR is ok:
ember-suaverules #732 to the.eslintrc.jsin a follow-on PR.ember-suaverules #732, and add the rule to the.eslintrc.jsas the rules are fixed.If I'm misunderstanding something please let me know!
cc @HospitalRun/core-maintainers