This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Fixes Issue 467 #538
Closed
Fixes Issue 467 #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `payment` model is created when hitting the `Add Payment` button on
invoices. This model is invalid, but it's creation sets the `paidTotal`
to 0. This set's `status` to 'Paid' for invoices requiring 0 payment.
- request adds additional logic to where the `status` field is set
- keeps track of last unpaid status if it needs to return to it
(e.g. return to either Bill or Draft)
- fixes missing checks for invalid payments when calculating remaining
balance
- implements cleanup function to destroy payment model placeholder
upon modal exit with invalid model state.
| cleanup: function() { | ||
| var model = this.model; | ||
| this.model.validate().then(function() { | ||
| model.save(); |
There was a problem hiding this comment.
This cleanup code should not save the model because the model should not be saved on the cancel action, it should only be saved when the user clicks on the update/add action which is already handled elsewhere in the controller.
|
@kaungst Thanks for the PR. I made some comments in your code changes. |
jkleinsc
added
the
in progress
|
@kaungst, hi. Are you planning to address this PR further or should we close it? |
|
@tangollama yup. Closing this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467
Problem Summary
paymentmodel is created when hitting theAdd Paymentbutton on invoices.paidTotalto 0.statusto 'Paid' for invoices requiring 0 payment.Fix Summary
statusfield is set(e.g. return to either Bill or Draft)
balance
upon modal exit with invalid model state.