This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Fixes #391 offline with service worker not working on new window/tab #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Epsilonnnn thanks for the PR! I wasn't expecting anyone to work on this issue, but I am thankful that you took interest in it. I'll take a look at your changes. |
|
Looks good @Epsilonnnn. I am going to merge it in. |
jkleinsc
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391 Offline with service worker not working on new window/tab.
Changes proposed in this pull request:
replicate.fromfunction return error, so change.then(loadConfig)to.finally(loadConfig)