Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Beef dat README [WIP - not ready to merge yet] #3

Merged
merged 3 commits into from
Jun 4, 2014
Merged

Conversation

jglovier
Copy link
Member

Getting setup to work on code is difficult with the existing state of the README. Let's flesh it out better to make working on the front-end much easier for anyone who wants to do so. ✨ 💥 ⚡

RENDERED

❤️ 🍰 📝 🍰 ❤️

Addresses #2

@jkleinsc
Copy link
Member

Any reason you did this as a PR instead of directly committing yourself?

@jglovier
Copy link
Member Author

Any reason you did this as a PR instead of directly committing yourself?

Yes, because I want to teach you to use GitHub flow. 😸 We should never commit directly to master, that's only for code cowboys. :trollface:

Seriously though, feature branching and pull requests allows for us to get the most benefit out of the collaborative process, forcing us to put multiple eyes on changes and to keep everyone aware of where things are headed, etc.

Plus, once we have CI setup, that will allow us to see if our changes break anything before merging them in (Travis FTW). I'd be happy to explain more about how to squeeze the most benefits out of this workflow, but here's a great articles that sum it up better than I will:

@jglovier
Copy link
Member Author

Any reason you did this as a PR instead of directly committing yourself?

Also, just because you can doesn't mean you should. Just because we are technically maintainers doesn't mean we shouldn't act like contributors. Behaving like contributors (at least workflow-wise) will give us a mentality that allows us to optimize for contributors. If you want to build a thriving OSS community around this project, we need to act like a group of contributors rather than a group of maintainers. ⚡

jglovier pushed a commit that referenced this pull request Jun 4, 2014
Beef dat README [WIP - not ready to merge yet]
@jglovier jglovier merged commit 277872e into master Jun 4, 2014
@jglovier jglovier deleted the readme-updates branch June 4, 2014 02:03
tangollama pushed a commit that referenced this pull request Feb 23, 2018
* JS scripts replacing bash scripts. Set of JS scripts, to replace bash scripts, for this project.
* Removing old shell scripts
tangollama pushed a commit that referenced this pull request May 12, 2018
jackcmeyer pushed a commit that referenced this pull request Apr 3, 2020
Merged from HospitalRun/hospitalrun-frontend
matteovivona pushed a commit that referenced this pull request Jan 15, 2021
Trying different config for CI/CD for Jest DOM matchers
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants