Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix: align cancel button #2768

Open
wants to merge 105 commits into
base: master
Choose a base branch
from
Open

fix: align cancel button #2768

wants to merge 105 commits into from

Conversation

kaushikpallavi7
Copy link

Fixes #2765.

Changes proposed in this pull request:

  • Align cancel buttons to the left in following 8 files:-
    • src/imagings/requests/NewImagingRequest.tsx
    • src/incidents/report/ReportIncident.tsx
    • src/labs/requests/NewLabRequest.tsx
    • src/medications/requests/NewMedicationRequest.tsx
    • src/patients/edit/EditPatient.tsx
    • src/patients/new/NewPatient.tsx
    • src/scheduling/appointments/edit/EditAppointment.tsx
    • src/scheduling/appointments/new/NewAppointment.tsx

@vercel
Copy link

vercel bot commented Oct 1, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/6f5NZ9hHVm3xHEvn4u7kQNjFJABf
✅ Preview: https://hospitalrun-frontend-git-fork-kaushikpallavi-cee1ec-hospitalrun.vercel.app

@RobertoMSousa
Copy link

Tested the UI and looks good. @kaushikpallavi7 but can you fix the title to match the semantic?
FIX: Cancel button align

RobertoMSousa
RobertoMSousa approved these changes Oct 1, 2021
View reviewed changes
Copy link

@RobertoMSousa RobertoMSousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR does what's expected but the number of changes (8 files) to do exactly the same suggests that this should be a component with those 2 buttons.

@kaushikpallavi7 kaushikpallavi7 changed the title Cancel button align Fix: Cancel button align Oct 2, 2021
@kaushikpallavi7
Copy link
Author

Tested the UI and looks good. @kaushikpallavi7 but can you fix the title to match the semantic? FIX: Cancel button align

Thanks @RobertoMSousa , I have changed the PR title.

@kaushikpallavi7
Copy link
Author

The PR does what's expected but the number of changes (8 files) to do exactly the same suggests that this should be a component with those 2 buttons.

Will commit with this change 👍🏻

@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Oct 2, 2021
@matteovivona matteovivona changed the title Fix: Cancel button align fix: cancel button align Oct 2, 2021
@matteovivona matteovivona changed the title fix: cancel button align fix: align cancel button Oct 2, 2021
@matteovivona
Copy link
Contributor

Tested the UI and looks good. @kaushikpallavi7 but can you fix the title to match the semantic? FIX: Cancel button align

Thanks @RobertoMSousa , I have changed the PR title.

@kaushikpallavi7 remember to use commit message like this: fix: fixes something or fix(layout): fixes something

@matteovivona matteovivona requested review from a team, fox1t, DrewGregory and anthonyaperez and removed request for a team October 2, 2021 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anthonyaperez anthonyaperez anthonyaperez requested changes

@RobertoMSousa RobertoMSousa RobertoMSousa approved these changes

@fox1t fox1t Awaiting requested review from fox1t fox1t was automatically assigned from HospitalRun/core-maintainers

@DrewGregory DrewGregory Awaiting requested review from DrewGregory DrewGregory was automatically assigned from HospitalRun/core-contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancel Button
4 participants
@kaushikpallavi7 @RobertoMSousa @matteovivona @anthonyaperez