feat(AppointmentsList): add an appointments tab to the patient view #1823
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/1qca0p36u |
|
Unit tests are pending. But wanted to get this out to start getting it reviewed. |
add an appointments tab to the patient view which shows appointments list for corresponding patient. Uses same layout as patient list view and also implements fuzzy search HospitalRun#1769
igeagonz
force-pushed
the
patient-appointment-list
branch
from
99f2b91
to
deee00e
Compare
| <ListItem action key={a.id} onClick={() => history.push(`/appointments/${a.id}`)}> | ||
| {`${t('scheduling.appointment.location')}: ${a.location} | ||
| ${t('scheduling.appointment.reason')}: ${a.reason} | ||
| ${t('scheduling.appointment.type')}: ${a.type} |
There was a problem hiding this comment.
location, reason and type aren't required fields when creating an appointment. Could conditionally render, but this would get ugly... unless someone has an idea 😄
There was a problem hiding this comment.
One bug that I noticed was that when on the `/patients/:id/appointments route, both appointments and patients are selected. I would expect that only patients was selected.
The problematic lines are:
Rather than using .includes we might want to match the start of the string instead.
| {`${t('scheduling.appointment.location')}: ${a.location} | ||
| ${t('scheduling.appointment.reason')}: ${a.reason} | ||
| ${t('scheduling.appointment.type')}: ${a.type} | ||
| ${t('scheduling.appointment.startDate')}: ${new Date(a.startDateTime).toLocaleString()} | ||
| ${t('scheduling.appointment.endDate')}: ${new Date(a.endDateTime).toLocaleString()}`} |
There was a problem hiding this comment.
I think for now, let's simply display the start date time of appointment.
Something like 2020-01-02 10:00am (except the internationalized version of that string).
Eventually, once the Table component is finished, we can migrate to that.
There was a problem hiding this comment.
Ok. I'll simply reduce it to just the Date.toLocaleString() which defaults to the locale it's running on.
Edit: Do note that the current search bar (which was out of scope) searches on the location, reason or type. In my opinion, having just the date would be a little less intuitive if only a date was displayed. Just something to consider.
| <TextInput | ||
| size="lg" | ||
| value={searchText} | ||
| placeholder={t('actions.search')} | ||
| onChange={onSearchBoxChange} | ||
| /> | ||
| <div className="input-group-append"> | ||
| <Button onClick={onSearchFormSubmit}>{t('actions.search')}</Button> | ||
| </div> |
There was a problem hiding this comment.
Now that we have two search boxes, we should consider abstracting that to a component in the /components folder.
| @@ -6,6 +6,38 @@ export class AppointmentRepository extends Repository<Appointment> { | |||
| constructor() { | |||
| super(appointments) | |||
| } | |||
|
|
|||
| // Fuzzy search for patient appointments. Used for patient appointment search bar | |||
| async searchPatientAppointments(patientId: string, text: string): Promise<Appointment[]> { | |||
There was a problem hiding this comment.
Searching this list is not something that I had previously considered. I think that this is a really neat idea!
@fox1t @tehkapa @lauggh @StefanoMiC,
What does everyone thing the requirements should be here? I see a really cool opportunity for having filter buttons for the different appointment types.
There was a problem hiding this comment.
We can leave it like this for now. We need to open a new feature issue to search about this. We really want a multi-field fuzzy search on almost every entity.
|
@igeagonz thanks for your contribution 🎉 |
…z/hospitalrun-frontend into patient-appointment-list
igeagonz
force-pushed
the
patient-appointment-list
branch
from
4195a55
to
a0ac600
Compare
| @@ -6,6 +6,38 @@ export class AppointmentRepository extends Repository<Appointment> { | |||
| constructor() { | |||
| super(appointments) | |||
| } | |||
|
|
|||
| // Fuzzy search for patient appointments. Used for patient appointment search bar | |||
| async searchPatientAppointments(patientId: string, text: string): Promise<Appointment[]> { | |||
There was a problem hiding this comment.
We can leave it like this for now. We need to open a new feature issue to search about this. We really want a multi-field fuzzy search on almost every entity.
|
Thanks for your contribution! 🎉🎉🎉🎉🎉 |
add an appointments tab to the patient view which shows appointments list for corresponding patient.
Uses same layout as patient list view and also implements fuzzy search
fixes #1769
Changes proposed in this pull request: