Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(patient-slice.ts): conditionally render family name and suffix #1822

Merged
merged 8 commits into from
Feb 13, 2020

Conversation

igeagonz
Copy link
Contributor

@igeagonz igeagonz commented Feb 12, 2020

Fixes #[1818]

Changes proposed in this pull request:

  • Currently family name and suffix are not required fields when creating a new patient or updating an existing one. Therefore, we should render patient.fullName in the Toast message/notification. The creation of patient.fullName already handles conditionally rendering family name and suffix if provided or not.
  • Refactor unit tests to use patient.fullName.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ignacio Gea seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@vercel
Copy link

vercel bot commented Feb 12, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/c0nz8216s
✅ Preview: https://hospitalrun-frontend-git-fork-igeagonz-new-patient-message-fix.hospitalrun.now.sh

@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Feb 13, 2020
@matteovivona matteovivona added this to the v2.0.0 milestone Feb 13, 2020
fox1t
fox1t previously approved these changes Feb 13, 2020
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matteovivona
Copy link
Contributor

matteovivona commented Feb 13, 2020

Hi @igeagonz, thanks for your contribution! Before we can merge your PR, can you sign our CLA?

src/patients/patient-slice.ts Outdated Show resolved Hide resolved
src/patients/patient-slice.ts Outdated Show resolved Hide resolved
@igeagonz
Copy link
Contributor Author

Hi @igeagonz, thanks for your contribution! Before we can merge your PR, can you sign our CLA?

Hey @tehkapa. I think at the time of my first commit, the email in that commit was not part of my github account. I then went and added it in my settings and I signed the agreement. When I click on the link it appears that I have already signed it with the email [email protected] and name Ignacio Gea. I just think the automated bot post is not updating.

@matteovivona matteovivona merged commit d5dacd6 into HospitalRun:master Feb 13, 2020
@igeagonz igeagonz deleted the new-patient-message-fix branch February 13, 2020 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants