This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Update README.md for typos and added links #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md for typos and added links for PouchDB, Docker.
jkleinsc
suggested changes
Apr 12, 2017
There was a problem hiding this comment.
@lisaychuang thank you for your PR! Can you make a slight change as suggested below? If so, I think we can merge this in.
README.md
Outdated
| @@ -170,7 +170,7 @@ To start coding and understand the frameworks, concepts and structure of the pro | |||
| ## Experimental | |||
|
|
|||
| ### Make | |||
| If you are willing to try using `make`, ensure you have installed git, node and couchdb (steps 1, 2 and 7 above), you may skip the rest. This requires couchdb in the path to work correctly. | |||
| If you are willing to try using `make`, ensure you have installed git, node and Couchdb (steps 1, 2 and 7 above), you may skip the rest. This requires Couchdb in the path to work correctly. | |||
There was a problem hiding this comment.
In order to be consistent with the rest of the doc, CouchDB should be referred to as CouchDB not Couchdb. Also, since you are changing the text here, can you change git to Git and node to Node.js for consistency as well?
Updated Readme.md to standardize names: CouchDB, Git, Node.js, Ember.js, EmberCLI.
|
@jkleinsc I've updated Readme.md per your review notes, thanks! |
jkleinsc
approved these changes
Apr 17, 2017
|
You are welcome, glad to help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md for typos and added links for PouchDB, Docker.
Does not fix any specific open issue.
Changes proposed in this pull request:
cc @HospitalRun/core-maintainers