Page Titles

[billybonks]

We currently assign page titles manually, instead we can make the following abstract classes, automatically figure out the page title, using the route name space.

-AbstractIndexRoute
-AbstractEditRoute
-AbstractModuleRoute
-AbstractDeleteController

i.e we have a titles.js translation that follows the same name spacing as the routes in the application. so for example:

inventory.index the page title will be under either titles.inventory.index = 'asd' or inventory.index.titles = 'asd'.

inventory.index the page title will be under inventory.index.title = 'asd'

the advantage of this is that the:

• CI will throw and error if a page title translation doesn't exist
• If needed the developer can always override the existing behaviour
• keeps title, translations in a tidy format for ever :).
• automatically fix the remaining titles to be translated :).

[tangollama]

I like this. @jkleinsc what do you think?

Sent using CloudMagic Email [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=7.11.40&pv=9.3.1&source=email_footer_2]
On Sun, Jul 3, 2016 at 5:04 AM, Sebastien Stettler [email protected] wrote:
We currently assign page titles manually, instead we can make the following abstract classes, automatically figure out the page title, using the route name space.

-AbstractIndexRoute
-AbstractEditRoute
-AbstractModuleRoute
-AbstractDeleteController

i.e we have a titles.js translation that follows the same name spacing as the routes in the application. so for example:

inventory.index the page title will be under either titles.inventory.index = 'asd' or inventory.index.titles = 'asd' .

the advantage of this is that the:

• CI will throw and error if a page title translation doesn't exist
• If needed the developer can always override the existing behaviour
• keeps title, translations in a tidy format for ever :).
• automatically fix the remaining titles to be translated :).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub [https://github.com//issues/551] , or mute the thread [https://github.com/notifications/unsubscribe/AA4t7SWWUQh5MJawyVIYIz3pUYaqDTEiks5qR3sqgaJpZM4JD1QT] .

[jkleinsc]

@billybonks I think this is a great idea. I would prefer the path to beinventory.index.title = 'asd'

[billybonks]

ye that is better 👍, also allows us to use route structure for other things if needed

[taras]

@wolfieorama would like to work on this issue. I'd like to assign it to him. No sure why it's not letting me.

[yasirunilan]

can i work on this?

[jkleinsc]

@yasirunilan @wolfieorama is currently assigned to this issue.

@wolfieorama are you working on this?

[wolfieorama]

@jkleinsc yes should be next in line

[yasirunilan]

I'm working on it

[wolfieorama]

cool no worries

[tangollama]

@yasirunilan any progress here?

[yasirunilan]

@tangollama sorry couldn't do it

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.