Duplicate Patient Modal cannot be triggered

[nobrayner]

🐛 Bug Report

While converting NewPatient.test.tsx to RTL, we found that the "Duplicate Patient Modal" is impossible to trigger by a user. It looks like it performs a de-dupe against the redux store, but there is nothing that ever populates that store with patients? Thus de-dupe never finds a duplicate.

Creating based on comment in #2516 (comment)

To Reproduce

Uncomment the "Duplicate Patient Modal" test and run it.

Expected behavior

The test would pass.

[nobrayner]

@jackcmeyer Creating this based on the comment in #2516

[morrme]

@nobrayner Are you working on a solution for this?

cc @jackcmeyer @tehkapa

[nobrayner]

@morrme no I am not - this was raised as an extra task above and beyond the conversion to RTL

[acrawford13]

Hi! If no one's working on this issue I'd be keen to work on it

[Giaddon]

Hello,

Looks like this issue is unassigned at the moment -- I'd like to work on it if that is the case. Thanks!

[connordmccandless]

Hi, could I be assigned to this issue if there's still help wanted?

[matteovivona]

@connordmccandless sure

[connordmccandless]

I fixed the duplicate patient modal so that from the UI, if you're trying to add a patient that could be a duplicate, the modal properly displays. However, I'm having trouble with the test. It seems to me that the test always fails. I changed the code to mark every new patient as a duplicate, so that from the UI, any patient added would prompt the duplicate patient modal. However, the test still did not say that it found the duplicate patient modal, and did not pass.

I was wondering if someone who's more knowledgeable about the testing libraries could take a look at the tests in NewPatient.test.sx and see if they should be functional.

[matteovivona]

thanks for the update @connordmccandless. create PR and then we'll see

[connordmccandless]

@tehkapa PR is created and attached to this issue